[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] migrate cancel bug in latest qemu upstream
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] migrate cancel bug in latest qemu upstream |
Date: |
Tue, 19 Mar 2013 10:39:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
Il 19/03/2013 05:49, Amos Kong ha scritto:
> On Mon, Mar 18, 2013 at 09:20:03PM +0800, Amos Kong wrote:
>> On Tue, Mar 12, 2013 at 10:58:54AM +0800, Amos Kong wrote:
>>> Hi quintela, I found a migrate bug in Autotest result, not sure if
>>> it's already known.
>
> This bug was already fixed by this patch:
>
> commit dba433c03a0f5dc22a459435dd89557886298921
> Author: Paolo Bonzini <address@hidden>
> Date: Fri Feb 22 17:36:17 2013 +0100
>
> migration: simplify error handling
>
> Always use qemu_file_get_error to detect errors, since that is how
> QEMUFile itself drops I/O after an error occurs. There is no need
> to propagate and check return values all the time.
>
> Also remove the "complete" member, since we know that it is set (via
> migrate_fd_cleanup) only when the state changes.
>
> Reviewed-by: Orit Wasserman <address@hidden>
> Reviewed-by: Juan Quintela <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Juan Quintela <address@hidden>
>
Should we add these patches to qemu-stable?
5da5aad (migration: simplify while loop, 2013-02-22)
891518a (migration: always use vm_stop_force_state, 2013-02-22)
7a2c172 (migration: move more error handling to migrate_fd_cleanup, 2013-02-22)
04943eb (migration: push qemu_savevm_state_cancel out of qemu_savevm_state_*,
2013-02-22)
93bf210 (qemu-file: pass errno from qemu_fflush via f->last_error, 2013-02-22)
47c8c17 (migration: use qemu_file_set_error to pass error codes back to
qemu_savevm_state, 2013-02-22)
4eb9381 (qemu-file: temporarily expose qemu_file_set_error and qemu_fflush,
2013-02-22)
f582151 (migration: flush all data to fd when buffered_flush is called,
2013-02-22)
63dfbd7 (migration: use qemu_file_set_error, 2013-02-22)
dba433c (migration: simplify error handling, 2013-02-22)
Paolo