Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

[Peter Lieven]

Am 19.03.2013 um 18:07 schrieb Paolo Bonzini <address@hidden>:

> Il 19/03/2013 16:54, Peter Lieven ha scritto:
>> On 19.03.2013 12:18, Paolo Bonzini wrote:
>>> Il 19/03/2013 09:51, Markus Armbruster ha scritto:
>>>> Paolo, please have a look.
>>> Why isn't it enough to call bdrv_init_with_whitelist earlier?
>>> 
>>> There is no conditional logic in it, the whitelist is checked at open
>>> time.
>> 
>> Has anyone tested if -spice is working?
> 
> It is.
> 
> machine_init entries are processed just below the other qemu_add_opts.

Ok, if you agree I would prepare a new version of this patch set with 3 patches:

1) move up brd_init_with_whitelist
2) throw an error if -iscsi is used without compile libiscsi support
3) assert that QemuOptsList != NULL to avoid further segfaults.

I currently see a segfault on VM start in libiscsi with latest git. Whereas my 
old
qemu-kvm 1.2.0 is working with the same command line and libiscsi library.
As soon as I have sorted this out I will send a new patch set.

Peter


> 
> Paolo
> 
> In this case
>> bdrv_init_with_whitelist() won't help here.
>> 
>> Anyway, I would like to change the -iscsi code in vl.c to throw an
>> error, if iscsi support is not
>> compiled in (like it is done with spice).
>> 
>> Peter
>> 
>>> 
>>> Paolo
>>> 
>>>> Peter Lieven <address@hidden> writes:
>>>> 
>>>>> current git master segfaults if an iscsi option is specified
>>>>> in command line.
>>>>> 
>>>>> Peter Lieven (2):
>>>>>   qemu-option: avoid segfault if QemuOptsList == NULL
>>>>>   vl.c: fix segfault in iscsi options parsing
>>>>> 
>>>>>  block/iscsi.c      |   27 ---------------------------
>>>>>  util/qemu-option.c |    1 +
>>>>>  vl.c               |   40 +++++++++++++++++++++++++++++++++++++---
>>>>>  3 files changed, 38 insertions(+), 30 deletions(-)
>>>> 
>> 
>> 
>