[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is spe
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified |
Date: |
Tue, 19 Mar 2013 20:29:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/18/2013 11:24 AM, Kevin Wolf wrote:
> The URL method already takes care to apply the default port when none is
> specfied. Directly specifying driver-specific options required the port
> number until now. Allow leaving it out and apply the default.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/nbd.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/block/nbd.c b/block/nbd.c
> index 218df6a..ac61b6d 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -119,20 +119,17 @@ static int nbd_parse_uri(const char *filename, QDict
> *options)
> qdict_put(options, "path", qstring_from_str(qp->p[0].value));
> } else {
> /* nbd[+tcp]://host:port/export */
Should this comment be rewritten as:
/* nbd[+tcp]://host[:port]/export */
But that's trivial, so:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename, (continued)
- [Qemu-devel] [PATCH 07/11] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 06/11] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 10/11] block: Allow omitting the file name when using driver-specific options, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified, Kevin Wolf, 2013/03/18
- Re: [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified,
Eric Blake <=