[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 09/12] block: Make find_image_format safe with NU
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v2 09/12] block: Make find_image_format safe with NULL filename |
Date: |
Wed, 20 Mar 2013 19:39:45 +0100 |
In order to achieve this, the .bdrv_probe callbacks of all drivers must
cope with this. The DMG driver is the only one that bases its decision
on the filename and it needs to be changed.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/dmg.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/block/dmg.c b/block/dmg.c
index c1066df..3141cb5 100644
--- a/block/dmg.c
+++ b/block/dmg.c
@@ -51,9 +51,16 @@ typedef struct BDRVDMGState {
static int dmg_probe(const uint8_t *buf, int buf_size, const char *filename)
{
- int len=strlen(filename);
- if(len>4 && !strcmp(filename+len-4,".dmg"))
- return 2;
+ int len;
+
+ if (!filename) {
+ return 0;
+ }
+
+ len = strlen(filename);
+ if (len > 4 && !strcmp(filename + len - 4, ".dmg")) {
+ return 2;
+ }
return 0;
}
--
1.8.1.4
- [Qemu-devel] [PATCH v2 00/12] block: Driver-specific options for protocols, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 02/12] block: Pass bdrv_file_open() options to block drivers, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 03/12] qemu-socket: Make socket_optslist public, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 01/12] block: Add options QDict to bdrv_file_open() prototypes, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 05/12] nbd: Remove unused functions, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 04/12] nbd: Keep hostname and port separate, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 08/12] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 09/12] block: Make find_image_format safe with NULL filename,
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 06/12] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 10/12] block: Allow omitting the file name when using driver-specific options, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 11/12] nbd: Use default port if only host is specified, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 07/12] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/20