[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option comb
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations |
|
Date: |
Wed, 20 Mar 2013 15:34:02 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/20/2013 12:39 PM, Kevin Wolf wrote:
> A file name may only specified if no host or socket path is specified.
> The latter two may not appear at the same time either.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/nbd.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
I'm assuming that the rest of the series is unchanged, on the commits
where you carried forward my v1 review.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 01/12] block: Add options QDict to bdrv_file_open() prototypes, (continued)
- [Qemu-devel] [PATCH v2 01/12] block: Add options QDict to bdrv_file_open() prototypes, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 05/12] nbd: Remove unused functions, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 04/12] nbd: Keep hostname and port separate, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 08/12] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 09/12] block: Make find_image_format safe with NULL filename, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 06/12] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 10/12] block: Allow omitting the file name when using driver-specific options, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 11/12] nbd: Use default port if only host is specified, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations, Kevin Wolf, 2013/03/20
- Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations,
Eric Blake <=
- [Qemu-devel] [PATCH v2 07/12] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/20