[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions |
Date: |
Wed, 20 Mar 2013 17:45:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/20/2013 05:23 PM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
> qapi-schema.json | 58
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
No counterpart change to qmp-commands.hx showing a valid usage?
> 1 files changed, 58 insertions(+), 0 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index fdaa9da..aae6767 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3442,3 +3442,61 @@
> # Since: 1.5
> ##
> { 'command': 'query-tpm', 'returns': ['TPMInfo'] }
> +
> +##
> +# @AcpiTableOptions
> +#
> +# Specify an ACPI table on the command line to load.
> +#
> +#
> +# @oem_id: #optional OEM identifier (6 bytes)
s/oem_id/oem-id/
In general, new QMP interfaces should use '-', not '_'.
> +#
> +# @file: #optional colon (:) separated list of pathnames to load and
> +# concatenate as table data. The resultant binary blob is expected to
> +# have an ACPI table header. At least one file is required. This field
> +# excludes @data.
> +#
Ewwww. This should be '*file' : [ 'str' ] (that is, use a JSON array of
file names, not a single string). If you have to reparse a JSON
argument to break it into parts, then you are using the wrong interface;
not to mention that I might (perversely) want to pass in a file name
that contains a colon as part of its name.
> +# @data: #optional colon (:) separated list of pathnames to load and
> +# concatenate as table data. The resultant binary blob must not have
> an
> +# ACPI table header. At least one file is required. This field
> excludes
> +# @file.
Again, JSON array, not flat string.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/11] build ACPI MADT for fw_cfg clients, Laszlo Ersek, 2013/03/20
- [Qemu-devel] [PATCH 01/11] strip some whitespace, Laszlo Ersek, 2013/03/20
- [Qemu-devel] [PATCH 02/11] change element type from "char" to "unsigned char" in ACPI table data, Laszlo Ersek, 2013/03/20
- [Qemu-devel] [PATCH 03/11] acpi_table_add(): report fatal errors through an internal Error object, Laszlo Ersek, 2013/03/20
- [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/20
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/20
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Paolo Bonzini, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Michael S. Tsirkin, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Paolo Bonzini, 2013/03/21
[Qemu-devel] [PATCH 05/11] acpi_table_add(): accept QemuOpts and parse it with OptsVisitor, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 07/11] like acpi_table_install(), acpi_table_add() should propagate Errors, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 06/11] acpi_table_add(): extract and reimplement internals, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 08/11] extract/unify the constant 0xfee00000 as APIC_DEFAULT_ADDRESS, Laszlo Ersek, 2013/03/20