[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function |
Date: |
Thu, 21 Mar 2013 11:47:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 03/21/2013 11:18 AM, Paolo Bonzini wrote:
> Il 21/03/2013 10:09, Orit Wasserman ha scritto:
>> Signed-off-by: Orit Wasserman <address@hidden>
>> ---
>> savevm.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/savevm.c b/savevm.c
>> index 35c8d1e..41dc87f 100644
>> --- a/savevm.c
>> +++ b/savevm.c
>> @@ -39,6 +39,7 @@
>> #include "qmp-commands.h"
>> #include "trace.h"
>> #include "qemu/bitops.h"
>> +#include "qemu/iov.h"
>>
>> #define SELF_ANNOUNCE_ROUNDS 5
>>
>> @@ -171,6 +172,18 @@ static void coroutine_fn yield_until_fd_readable(int fd)
>> qemu_coroutine_yield();
>> }
>>
>> +static int socket_writev_buffer(void *opaque, struct iovec *iov, int iovcnt)
>> +{
>> + QEMUFileSocket *s = opaque;
>> + ssize_t len;
>> +
>> + len = iov_writev(s->fd, iov, iovcnt);
>> + if (len < iov_size(iov, iovcnt)) {
>> + len = -socket_error();
>> + }
>> + return len;
>> +}
>
> This doesn't work on Windows, you need iov_send:
>
> ssize_t iov_send(int sockfd, struct iovec *iov, unsigned iov_cnt,
> size_t offset, size_t bytes);
>
iov_writev is implemented like iov_send the only difference is that it uses
writev and not sendmsg
so it can work on files.
So in windows it will use send.
Orit
> Paolo
>
> +
>> static int socket_get_fd(void *opaque)
>> {
>> QEMUFileSocket *s = opaque;
>> @@ -387,6 +400,7 @@ static const QEMUFileOps socket_read_ops = {
>> static const QEMUFileOps socket_write_ops = {
>> .get_fd = socket_get_fd,
>> .put_buffer = socket_put_buffer,
>> + .writev_buffer = socket_writev_buffer,
>> .close = socket_close
>> };
>>
>>
>
[Qemu-devel] [RFC 04/12] Add stdio_writev_buffer function, Orit Wasserman, 2013/03/21
[Qemu-devel] [RFC 05/12] Add block_writev_buffer function, Orit Wasserman, 2013/03/21
[Qemu-devel] [RFC 06/12] Update bytes_xfer in qemu_put_byte, Orit Wasserman, 2013/03/21
[Qemu-devel] [RFC 07/12] Store the data to send also in iovec, Orit Wasserman, 2013/03/21