[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option comb
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations |
|
Date: |
Thu, 21 Mar 2013 11:29:59 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 20.03.2013 um 22:34 hat Eric Blake geschrieben:
> On 03/20/2013 12:39 PM, Kevin Wolf wrote:
> > A file name may only specified if no host or socket path is specified.
> > The latter two may not appear at the same time either.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > block/nbd.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> I'm assuming that the rest of the series is unchanged, on the commits
> where you carried forward my v1 review.
I think I've added a spelling fix or two for things you pointed out, but
other than that they are unchanged, yes.
Thanks for your review, Eric!
Kevin
- [Qemu-devel] [PATCH v2 05/12] nbd: Remove unused functions, (continued)
- [Qemu-devel] [PATCH v2 05/12] nbd: Remove unused functions, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 04/12] nbd: Keep hostname and port separate, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 08/12] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 09/12] block: Make find_image_format safe with NULL filename, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 06/12] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 10/12] block: Allow omitting the file name when using driver-specific options, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 11/12] nbd: Use default port if only host is specified, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations, Kevin Wolf, 2013/03/20
- [Qemu-devel] [PATCH v2 07/12] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/20