[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions |
Date: |
Thu, 21 Mar 2013 13:44:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 21/03/2013 13:42, Laszlo Ersek ha scritto:
> On 03/21/13 13:36, Michael S. Tsirkin wrote:
>> On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote:
>>> Il 21/03/2013 11:41, Laszlo Ersek ha scritto:
>>>> On 03/21/13 01:31, Laszlo Ersek wrote:
>>>>> On 03/21/13 00:45, Eric Blake wrote:
>>>>>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote:
>>>>
>>>>>>> +#
>>>>>>> +# @oem_id: #optional OEM identifier (6 bytes)
>>>>>>
>>>>>> s/oem_id/oem-id/
>>>>>>
>>>>>> In general, new QMP interfaces should use '-', not '_'.
>>>>>
>>>>> Indeed! I think this warrants a respin.
>>>>
>>>> Actually it doesn't, apologies -- I got confused for a minute. Again,
>>>> since I aim to match the existing option format, I must keep the same
>>>> spelling.
>>>
>>> We should make a list of places where we have mixed conventions, accept
>>> both, and mass-convert to dash...
>>>
>>> Paolo
>>
>> Anthony used to nack all mass conversions since they mess up the git
>> history. Since the movement of headers went in, I gather this position
>> has been relaxed...
>>
>
> Paolo, what are you suggesting precisely?
Using something like
int strcmp_dash(const char *a, const char *b)
{
char p, q;
for (;; a++, b++) {
p = *a == '_' ? '-' : *a;
q = *b == '_' ? '-' : *b;
a++, b++;
} while (p == q && p != 0);
return p - q;
}
in QemuOpts, the monitor, etc. The mass conversion isn't really
necessary, just for cleanliness.
Paolo
- Re: [Qemu-devel] [PATCH 02/11] change element type from "char" to "unsigned char" in ACPI table data, (continued)
- [Qemu-devel] [PATCH 03/11] acpi_table_add(): report fatal errors through an internal Error object, Laszlo Ersek, 2013/03/20
- [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/20
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Eric Blake, 2013/03/20
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/20
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Paolo Bonzini, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Michael S. Tsirkin, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions, Laszlo Ersek, 2013/03/21
- Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions,
Paolo Bonzini <=
[Qemu-devel] [PATCH 05/11] acpi_table_add(): accept QemuOpts and parse it with OptsVisitor, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 07/11] like acpi_table_install(), acpi_table_add() should propagate Errors, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 06/11] acpi_table_add(): extract and reimplement internals, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 08/11] extract/unify the constant 0xfee00000 as APIC_DEFAULT_ADDRESS, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 10/11] pc_acpi_init(): don't bail as soon as failing to find default DSDT, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 09/11] Introduce IO_APIC_DEFAULT_ADDRESS for 0xfec00000, Laszlo Ersek, 2013/03/20
[Qemu-devel] [PATCH 11/11] i386/pc: build ACPI MADT for fw_cfg clients, Laszlo Ersek, 2013/03/20