[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 3/9] buffer_is_zero: use vector optimizations
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv3 3/9] buffer_is_zero: use vector optimizations if possible |
Date: |
Thu, 21 Mar 2013 12:16:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/21/2013 09:57 AM, Peter Lieven wrote:
> performance gain on SSE2 is approx. 20-25%. altivec
> is not tested. performance for unsigned long arithmetic
> is unchanged.
>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> util/cutils.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/util/cutils.c b/util/cutils.c
> index 6d079ac..52205a2 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -210,6 +210,11 @@ bool buffer_is_zero(const void *buf, size_t len)
> long d0, d1, d2, d3;
> const long * const data = buf;
>
> + /* use vector optimized zero check if possible */
> + if (can_use_buffer_find_nonzero_offset(buf,len)) {
Space after comma.
> + return buffer_find_nonzero_offset(buf, len)==len;
And still missing spaces around the '==', even though I pointed it out
in v2. Run your series through checkpatch.pl.
As whitespace cleanups are trivial, you can send v4 with:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCHv3 2/9] cutils: add a function to find non-zero content in a buffer, (continued)
- [Qemu-devel] [PATCHv3 2/9] cutils: add a function to find non-zero content in a buffer, Peter Lieven, 2013/03/21
- [Qemu-devel] [PATCHv3 9/9] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/21
- [Qemu-devel] [PATCHv3 5/9] migration: search for zero instead of dup pages, Peter Lieven, 2013/03/21
- [Qemu-devel] [PATCHv3 6/9] migration: add an indicator for bulk state of ram migration, Peter Lieven, 2013/03/21
- [Qemu-devel] [PATCHv3 3/9] buffer_is_zero: use vector optimizations if possible, Peter Lieven, 2013/03/21
- Re: [Qemu-devel] [PATCHv3 3/9] buffer_is_zero: use vector optimizations if possible,
Eric Blake <=