qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [Qemu-stable][PATCH] tcg: Fix occasional TCG broken problem


From: Yeongkyoon Lee
Subject: [Qemu-devel] [Qemu-stable][PATCH] tcg: Fix occasional TCG broken problem when ldst optimization enabled
Date: Fri, 22 Mar 2013 20:28:54 +0900

is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
enabled. The reason is code_gen_buffer_max_size does not cover the upper range
up to (TCG_MAX_OP_SIZE * OPC_BUF_SIZE), thus code_gen_buffer_max_size should be
modified to code_gen_buffer_size.

Signed-off-by: Yeongkyoon Lee <address@hidden>
---

Here's is the promised patch with Aurelien Jarno for TCG broken problem, which
is supposed to be applied to 1.3.x and 1.4.x releases as well as master.
Thanks to Aurelien Jarno and Stefan Weil.

 translate-all.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/translate-all.c b/translate-all.c
index 1f3237e..7851e1a 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1312,7 +1312,7 @@ bool is_tcg_gen_code(uintptr_t tc_ptr)
        is used instead of code_gen_ptr for upper boundary checking */
     return (tc_ptr >= (uintptr_t)tcg_ctx.code_gen_buffer &&
             tc_ptr < (uintptr_t)(tcg_ctx.code_gen_buffer +
-                    tcg_ctx.code_gen_buffer_max_size));
+                    tcg_ctx.code_gen_buffer_size));
 }
 #endif
 
-- 
1.7.9.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]