Re: [Qemu-devel] [PATCH 12/26] hw/ccid-card-passthru.c: add atr check

[Alon Levy]

> On Mon, Mar 18, 2013 at 2:10 PM, Alon Levy <address@hidden> wrote:
> > +    if (len > 2 + historical_length + opt_bytes) {
> > +        DPRINTF(card, D_WARN,
> > +            "atr too long: len %d, but hist/opt %d/%d, T1 0x%X\n",
> > +            len, historical_length, opt_bytes, data[1]);
> > +        /* let it through */
> 
> Why "let it through" if it's too long?

I know windows doesn't like too short, but no idea about too long. Haven't seen 
this in practice yet (well, we control the other end too, but I saw no reason 
to fail it at this point).

> 
> 
> --
> Marc-André Lureau
> 
>