[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/14] nbd: Keep hostname and port separate
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/14] nbd: Keep hostname and port separate |
Date: |
Fri, 22 Mar 2013 23:46:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 22/03/2013 18:41, Kevin Wolf ha scritto:
> + QemuOpts *opts = qemu_opts_create_nofail(&socket_optslist);
> +
> + qemu_opt_set(opts, "host", s->inet_addr->host);
> + qemu_opt_set(opts, "port", s->inet_addr->port);
> + if (s->inet_addr->has_to) {
> + qemu_opt_set_number(opts, "to", s->inet_addr->to);
> + }
> + if (s->inet_addr->has_ipv4) {
> + qemu_opt_set_number(opts, "ipv4", s->inet_addr->ipv4);
> + }
> + if (s->inet_addr->has_ipv6) {
> + qemu_opt_set_number(opts, "ipv6", s->inet_addr->ipv6);
> + }
> +
> + sock = tcp_socket_outgoing_opts(opts);
Sorry for the late review... You're basically reinventing socket_connect
here. Would like to clean it up or shall I do it?
Paolo
- [Qemu-devel] [PATCH 07/14] nbd: Remove unused functions, (continued)
- [Qemu-devel] [PATCH 07/14] nbd: Remove unused functions, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 08/14] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 05/14] qemu-socket: Make socket_optslist public, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 10/14] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 11/14] block: Make find_image_format safe with NULL filename, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 03/14] block: Add options QDict to bdrv_file_open() prototypes, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 14/14] nbd: Check against invalid option combinations, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 06/14] nbd: Keep hostname and port separate, Kevin Wolf, 2013/03/22
- Re: [Qemu-devel] [PATCH 06/14] nbd: Keep hostname and port separate,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 09/14] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 12/14] block: Allow omitting the file name when using driver-specific options, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 13/14] nbd: Use default port if only host is specified, Kevin Wolf, 2013/03/22