qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output
Date: Sun, 24 Mar 2013 18:38:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4

Am 27.02.2013 10:37, schrieb Jan Kiszka:
> On 2013-02-27 10:33, Andreas Färber wrote:
>> Am 27.02.2013 10:15, schrieb Jan Kiszka:
>>> Several issues fixed:
>>>  - We were missing a bunch of feature lists. Fix this by simply dumping
>>>    the meta list feature_word_info.
>>>  - kvm_enabled() cannot be true at this point because accelerators are
>>>    initialized much later during init. Also, hiding this makes it very
>>>    hard to discover for users. Simply dump unconditionally if CONFIG_KVM
>>>    is set.
>>>  - Add explanation for "host" CPU type.
>>>
>>> Signed-off-by: Jan Kiszka <address@hidden>
>>> ---
>>>
>>> Changes in v2:
>>>  - Do not dump "host" type if CONFIG_KVM is not set
>>>  - Explain that "host" depends on KVM mode
>>
>> I had requested on v1 to not fix multiple issues in one patch, but I can
>> split it myself on Friday if there's no other issues.
> 
> Sorry, missed that. But I also see no point in splitting up in this
> case, specifically as we no agree on the result.

Thanks, applied to qom-cpu as two patches (clean git-checkout -p split):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Sorry for taking so long.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]