[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm_mptimer: Save the timer state
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm_mptimer: Save the timer state |
Date: |
Mon, 25 Mar 2013 10:38:40 +1000 |
Hi Peter,
On Sat, Mar 23, 2013 at 1:49 AM, Peter Maydell <address@hidden> wrote:
> Add a missing VMSTATE_TIMER() entry to the arm_mptimer vmstate
> description; this omission meant that we would probably hang on reload
> when the timer failed to fire.
>
I know load-save does not work for Zynq Linux. This will definately
help get us closer to a working state. Might have another go to see if
it gets any further with this. Thanks.
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> hw/arm_mptimer.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm_mptimer.c b/hw/arm_mptimer.c
> index f59a9f1..317f5e4 100644
> --- a/hw/arm_mptimer.c
> +++ b/hw/arm_mptimer.c
> @@ -253,14 +253,15 @@ static int arm_mptimer_init(SysBusDevice *dev)
>
> static const VMStateDescription vmstate_timerblock = {
> .name = "arm_mptimer_timerblock",
> - .version_id = 1,
> - .minimum_version_id = 1,
> + .version_id = 2,
> + .minimum_version_id = 2,
> .fields = (VMStateField[]) {
> VMSTATE_UINT32(count, TimerBlock),
> VMSTATE_UINT32(load, TimerBlock),
> VMSTATE_UINT32(control, TimerBlock),
> VMSTATE_UINT32(status, TimerBlock),
> VMSTATE_INT64(tick, TimerBlock),
> + VMSTATE_TIMER(timer, TimerBlock),
> VMSTATE_END_OF_LIST()
> }
> };
> --
> 1.7.9.5
>
>