[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 6/9] migration: add an indicator for bulk stat
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCHv4 6/9] migration: add an indicator for bulk state of ram migration |
Date: |
Mon, 25 Mar 2013 11:32:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 03/22/2013 02:46 PM, Peter Lieven wrote:
> the first round of ram transfer is special since all pages
> are dirty and thus all memory pages are transferred to
> the target. this patch adds a boolean variable to track
> this stage.
>
> Signed-off-by: Peter Lieven <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> arch_init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch_init.c b/arch_init.c
> index 9ebca83..4c4caf4 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -317,6 +317,7 @@ static ram_addr_t last_offset;
> static unsigned long *migration_bitmap;
> static uint64_t migration_dirty_pages;
> static uint32_t last_version;
> +static bool ram_bulk_stage;
>
> static inline
> ram_addr_t migration_bitmap_find_and_reset_dirty(MemoryRegion *mr,
> @@ -424,6 +425,7 @@ static int ram_save_block(QEMUFile *f, bool last_stage)
> if (!block) {
> block = QTAILQ_FIRST(&ram_list.blocks);
> complete_round = true;
> + ram_bulk_stage = false;
> }
> } else {
> uint8_t *p;
> @@ -527,6 +529,7 @@ static void reset_ram_globals(void)
> last_sent_block = NULL;
> last_offset = 0;
> last_version = ram_list.version;
> + ram_bulk_stage = true;
> }
>
> #define MAX_WAIT 50 /* ms, half buffered_file limit */
>
Reviewed-by: Orit Wasserman <address@hidden>
- Re: [Qemu-devel] [PATCHv4 5/9] migration: search for zero instead of dup pages, (continued)
- [Qemu-devel] [PATCHv4 3/9] buffer_is_zero: use vector optimizations if possible, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 8/9] migration: do not search dirty pages in bulk stage, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 1/9] move vector definitions to qemu-common.h, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 9/9] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 4/9] bitops: use vector algorithm to optimize find_next_bit(), Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 6/9] migration: add an indicator for bulk state of ram migration, Peter Lieven, 2013/03/22
- Re: [Qemu-devel] [PATCHv4 6/9] migration: add an indicator for bulk state of ram migration,
Orit Wasserman <=
- [Qemu-devel] [PATCHv4 2/9] cutils: add a function to find non-zero content in a buffer, Peter Lieven, 2013/03/22
- Re: [Qemu-devel] [PATCHv4 2/9] cutils: add a function to find non-zero content in a buffer, Orit Wasserman, 2013/03/25