Re: [Qemu-devel] [PATCH 2/2] vl.c: throw an error if iscsi is not supported

[Peter Lieven]

Am 25.03.2013 um 15:00 schrieb Stefan Hajnoczi <address@hidden>:

> On Thu, Mar 21, 2013 at 01:07:11PM +0100, Peter Lieven wrote:
>> this patch adds a check for qemu_find_opts("iscsi") returning
>> NULL instead of blindly passing the result to qemu_opts_parse().
>> 
>> Signed-off-by: Peter Lieven <address@hidden>
>> ---
>> vl.c |    9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
> 
> Why is this change necessary?

a) just to make sure we check the result of qemu_find_opts for NULL in case
a bug stops registering the opts again
b) to have an error output if libiscsi is not compiled in and someone passes
an iscsi flag (analogue to the error if you supply -spice XXX)

Peter


> 
> Stefan