Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy

[Michael R. Hines]

Right, the header's not used - but, are we certain that 
put_buffer_copy() will *always* be used for RAM in the future?

- Michael

On 03/25/2013 09:05 AM, Paolo Bonzini wrote:
> ----- Messaggio originale -----
> > Da: "Michael R. Hines" <address@hidden>
> > A: "Orit Wasserman" <address@hidden>
> > Cc: address@hidden, address@hidden, address@hidden, "chegu vinod" 
> > <address@hidden>,
> > address@hidden
> > Inviato: Sabato, 23 marzo 2013 17:27:49
> > Oggetto: Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy
> >
> > Can you add a "flag" or something to indicate that the iov pointer
> > belongs to RAM and not to device state?
> >
> > That way, I could re-use this code for RDMA - if I see this flag, I
> > will know to send to RDMA.....
> I am not sure you can, because the function will be preceded by
> a qemu_put_be64 to store the header.  That header is not sent in
> the RDMA case, isn't it?
>
> Paolo