[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 00/11] Fix versatile_pci (now without breaking li
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v2 00/11] Fix versatile_pci (now without breaking linux) |
Date: |
Tue, 26 Mar 2013 10:22:00 +0000 |
This patch series fixes a number of serious bugs in our emulation of
the PCI controller found on VersatilePB and the early Realview boards:
* our interrupt mapping was totally wrong
* we weren't implementing the PCI memory windows
* the I/O window wasn't mapped on VersatilePB
* realview mapped things at the wrong addresses
* we didn't implement the controller's registers at all
It also updates to some reasonable approximation to QOM best practice,
including subclassing pci_host rather than doing everything by hand.
I haven't implemented support for the SMAP registers (which control
how the controller converts accesses made by bus-mastering PCI
devices into system addresses). For the moment we rely on the fact
that Linux always maps things 1:1. (It wouldn't be too hard to add
SMAP support but it requires changing QEMU's pci code to allow a
controller to pass in a MemoryRegion* for DMA to use instead of
the system address space, so I prefer to leave that for another series.)
Patchset tested on both versatilepb and realview, using a set of
Linux kernel patches written by Arnd Bergmann:
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-October/029040.html
which were in turn tested against real PB926 and PB1176 hardware.
This version of the patchset avoids breaking legacy Linux guests
by automatically detecting those broken kernels and switching back
to the old mapping. This works by looking at the values the kernel
writes to the PCI_INTERRUPT_LINE register in the config space, which
is effectively the interrupt number the kernel expects the device
to be using. If this doesn't match reality we use the broken mapping.
(Thanks to Michael S. Tsirkin for this suggestion.)
I haven't included any mechanism for forcing this autodetection off.
Changes v1->v2:
* autodetect broken guests rather than using user-set property
* use pci_swizzle_map_fn
* new patch: drop unnecessary vpb_pci_config_addr() function
Peter Maydell (11):
versatile_pci: Fix hardcoded tabs
versatile_pci: Expose PCI I/O region on Versatile PB
versatile_pci: Update to realize and instance init functions
versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE
versatile_pci: Use separate PCI I/O space rather than system I/O space
versatile_pci: Put the host bridge PCI device at slot 29
versatile_pci: Implement the correct PCI IRQ mapping
versatile_pci: Implement the PCI controller's control registers
arm/realview: Fix mapping of PCI regions
versatile_pci: Expose PCI memory space to system
hw/versatile_pci: Drop unnecessary vpb_pci_config_addr()
hw/arm/realview.c | 22 +--
hw/arm/versatilepb.c | 11 +-
hw/versatile_pci.c | 386 +++++++++++++++++++++++++++++++++++++++++++-------
3 files changed, 358 insertions(+), 61 deletions(-)
--
1.7.9.5
- [Qemu-devel] [PATCH v2 00/11] Fix versatile_pci (now without breaking linux),
Peter Maydell <=
- [Qemu-devel] [PATCH v2 11/11] hw/versatile_pci: Drop unnecessary vpb_pci_config_addr(), Peter Maydell, 2013/03/26
- [Qemu-devel] [PATCH v2 10/11] versatile_pci: Expose PCI memory space to system, Peter Maydell, 2013/03/26
- [Qemu-devel] [PATCH v2 09/11] arm/realview: Fix mapping of PCI regions, Peter Maydell, 2013/03/26
- [Qemu-devel] [PATCH v2 06/11] versatile_pci: Put the host bridge PCI device at slot 29, Peter Maydell, 2013/03/26
- [Qemu-devel] [PATCH v2 01/11] versatile_pci: Fix hardcoded tabs, Peter Maydell, 2013/03/26
- [Qemu-devel] [PATCH v2 02/11] versatile_pci: Expose PCI I/O region on Versatile PB, Peter Maydell, 2013/03/26
- [Qemu-devel] [PATCH v2 07/11] versatile_pci: Implement the correct PCI IRQ mapping, Peter Maydell, 2013/03/26