[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/22] instrument: Add commandline options to st
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 16/22] instrument: Add commandline options to start with an instrumentation library |
Date: |
Tue, 26 Mar 2013 08:59:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/26/2013 08:01 AM, Lluís Vilanova wrote:
> Add commandline options to control initial loading of dynamic instrumentation
> library.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> +++ b/instrument/cmdline.c
> @@ -0,0 +1,94 @@
> +/*
> + * Control dynamic trace instrumentation during program (de)initialization.
> + *
> + * Copyright (C) 2012 Lluís Vilanova <address@hidden>
It's 2013.
> +
> +static bool loaded = false;
Static variables are already 0-initialized; not all compilers can
optimize an explicit 0-initialization into bss, so it is better to omit
'= false'.
> +
> + exit(-1);
Exiting with status 255 is unusual (twice this patch).
> +++ b/linux-user/main.c
> @@ -34,6 +34,8 @@
> #include "qemu/timer.h"
> #include "qemu/envlist.h"
> #include "elf.h"
> +#include "instrument/cmdline.h"
> +
>
> char *exec_path;
>
> @@ -3242,6 +3244,22 @@ static void handle_arg_reserved_va(const char *arg)
> }
> #endif
>
> +static const char *instrument_path = NULL;
Another case of not needing explicit 0-initialization.
> +++ b/qmp-commands.hx
> @@ -1519,6 +1519,7 @@ Load a dynamic instrumentation library.
> Arguments:
>
> - path: path to the dynamic instrumentation library
> +- args: arguments to the dynamic instrumentation library
This should have been in an earlier patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 08/22] instrument: [static] Call statically linked user-provided routines, (continued)
- [Qemu-devel] [PATCH 08/22] instrument: [static] Call statically linked user-provided routines, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 09/22] instrument: [dynamic] Call dynamically linked user-provided routines, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 10/22] instrument: Add internal control interface, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 12/22] qapi: Add a primitive to include other files from a QAPI schema file, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 11/22] instrument: [hmp] Add control interface, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 13/22] [trivial] Set the input root directory when parsing QAPI files, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 15/22] Let makefiles add entries to the set of target architecture objects, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 14/22] instrument: [qmp, qapi] Add control interface, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 16/22] instrument: Add commandline options to start with an instrumentation library, Lluís Vilanova, 2013/03/26
- Re: [Qemu-devel] [PATCH 16/22] instrument: Add commandline options to start with an instrumentation library,
Eric Blake <=
- [Qemu-devel] [PATCH 18/22] instrument: Add client-side API to control tracing state of events, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 17/22] instrument: Add client-side API to enumerate events, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 19/22] instrument: Add client-side API to control event instrumentation, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 20/22] build: Fix installation of target-dependant files, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 21/22] instrument: Install headers for dynamic instrumentation clients, Lluís Vilanova, 2013/03/26
- [Qemu-devel] [PATCH 22/22] trace: Do not use the word 'new' in event arguments, Lluís Vilanova, 2013/03/26