Re: [Qemu-devel] [PATCH 11/12 v3] qmp: add cpu-add qmp command

[Igor Mammedov]

On Tue, 26 Mar 2013 10:54:39 -0600
Eric Blake <address@hidden> wrote:

> On 03/26/2013 10:47 AM, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > v3:
> >   * it appears that 'online/offline' in cpu-set are confusing people
> >     with what command actually does and users might have to distinguish
> >     if 'offline' is not implemented by parsing error message. To simplify
> >     things replace cpu-set with cpu-add command to show more clear what
> >     command does and just add cpu-del when CPU remove is implemented.
> > 
> > v2:
> >   * s/cpu_set/cpu-set/
> >   * qmp doc style fix
> >   * use bool type instead of opencodding online/offline string
> >      suggested-by: Eric Blake <address@hidden>
> > ---
> >  include/sysemu/sysemu.h |  2 ++
> >  qapi-schema.json        | 11 +++++++++++
> >  qmp-commands.hx         | 23 +++++++++++++++++++++++
> >  qmp.c                   |  5 +++++
> >  stubs/Makefile.objs     |  1 +
> >  stubs/do_cpu_hot_add.c  |  7 +++++++
> >  6 files changed, 49 insertions(+)
> >  create mode 100644 stubs/do_cpu_hot_add.c
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> I didn't look at the rest of your series (I guess the remaining patches
> were only posted in v1?)
Yes, remaining patches in RFC v1. Sorry, I've forgot to add
reference when posting this patch to stick it in related mail thread.
Also there is updated git tree
https://github.com/imammedo/qemu/tree/cpu_set.WIP with this patch.

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


-- 
Regards,
  Igor