[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/10] target-i386: SSE4.2: fix pcmpgtq instruction
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] [PATCH 02/10] target-i386: SSE4.2: fix pcmpgtq instruction |
Date: |
Tue, 26 Mar 2013 20:01:34 +0100 |
The "Intel 64 and IA-32 Architectures Software Developer's Manual" (at
least recent versions) clearly says that the comparison is signed.
Signed-off-by: Aurelien Jarno <address@hidden>
---
target-i386/ops_sse.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h
index cad9d75..0136df9 100644
--- a/target-i386/ops_sse.h
+++ b/target-i386/ops_sse.h
@@ -1933,8 +1933,7 @@ void glue(helper_mpsadbw, SUFFIX)(CPUX86State *env, Reg
*d, Reg *s,
}
/* SSE4.2 op helpers */
-/* it's unclear whether signed or unsigned */
-#define FCMPGTQ(d, s) (d > s ? -1 : 0)
+#define FCMPGTQ(d, s) ((int64_t)d > (int64_t)s ? -1 : 0)
SSE_HELPER_Q(helper_pcmpgtq, FCMPGTQ)
static inline int pcmp_elen(CPUX86State *env, int reg, uint32_t ctrl)
--
1.7.10.4
- [Qemu-devel] [PATCH 00/10] target-i386: fix and enable SSE4.1 and SSE4.2, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 08/10] target-i386: SSE4.2: fix pcmpXstrX instructions with "Masked(-)" polarity, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 05/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Ranges" mode, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 03/10] target-i386: SSE4.2: fix pcmpXstri instructions, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 04/10] target-i386: SSE4.2: fix pcmpXstrm instructions, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 02/10] target-i386: SSE4.2: fix pcmpgtq instruction,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 09/10] target-i386: enable SSE4.1 and SSE4.2 in TCG mode, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 10/10] target-i386: SSE4.2: use clz32/ctz32 instead of reinventing the wheel, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 06/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Equal each" mode, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 01/10] target-i386: SSE4.1: fix pinsrb instruction, Aurelien Jarno, 2013/03/26
- [Qemu-devel] [PATCH 07/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Equal ordered" mode, Aurelien Jarno, 2013/03/26