Re: [Qemu-devel] [PATCH 1/4] net: ensure "socket" backend uses non-blocking fds

[Stefan Hajnoczi]

On Tue, Mar 26, 2013 at 10:33:45AM -0600, Eric Blake wrote:
> On 03/26/2013 10:07 AM, Stefan Hajnoczi wrote:
> > There are several code paths in net_init_socket() depending on how the
> > socket is created: file descriptor passing, UDP multicast, TCP, or UDP.
> > Some of these support both listen and connect.
> > 
> > Not all code paths set the socket to non-blocking.  This patch addresses
> > the file descriptor passing and UDP cases which were missing
> > socket_set_nonblock(fd) calls.
> > 
> > I considered moving socket_set_nonblock(fd) to a central location but it
> > turns out the code paths are different enough to require non-blocking at
> > different places.
> 
> Is it worth rearranging patch 3 first, so that you don't have to churn
> on these newly-added lines?

Will do that in v2.

Stefan