[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/26] hw/usb/dev-smartcard-reader.c: copy atr's
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH 18/26] hw/usb/dev-smartcard-reader.c: copy atr's protocol to ccid's parameters (adds todo's) |
Date: |
Wed, 27 Mar 2013 17:06:15 +0200 |
User-agent: |
Mutt/1.5.21 (2012-12-30) |
On Fri, Mar 22, 2013 at 03:23:15PM +0100, Marc-André Lureau wrote:
> Hi,
>
>
> On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy <address@hidden> wrote:
> > + if (atr_protocol_num == 0) {
> > + DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T0 parameters"
> > + " setting\n", __func__);
> > + t0->bmFindexDindex = 0;
> > + t0->bmTCCKST0 = 0;
> > + t0->bGuardTimeT0 = 0;
> > + t0->bWaitingIntegerT0 = 0;
> > + t0->bClockStop = 0;
> > + } else {
> > + if (atr_protocol_num != 1) {
> > + DPRINTF(s, D_WARN, "%s: error: unsupported ATR protocol %d\n",
> > + __func__, atr_protocol_num);
> > + } else {
> > + DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T1 parameters"
> > + " setting\n", __func__);
> > + t1->bmFindexDindex = 0;
> > + t1->bmTCCKST1 = 0;
> > + t1->bGuardTimeT1 = 0;
> > + t1->bWaitingIntegerT1 = 0;
> > + t1->bClockStop = 0;
> > + t1->bIFSC = 0;
> > + t1->bNadValue = 0;
> > + }
> > + }
>
> Those blocks could be at the same indentation level, or perhaps use a switch?
A switch is a good idea.
>
> Is it sensible to warn in all cases?
Turning them into TODO comments instead (except for the now default
case).
>
> --
> Marc-André Lureau
>
- Re: [Qemu-devel] [PATCH 23/26] libcacard: change default ATR, (continued)
- [Qemu-devel] [PATCH 19/26] hw/usb/dev-smartcard-reader.c: dwFeadvertise support for T=0 only, Alon Levy, 2013/03/18
- [Qemu-devel] [PATCH 25/26] dev-smartcard-reader: empty implementation for Mechanical (fail correctly), Alon Levy, 2013/03/18
- [Qemu-devel] [PATCH 24/26] libcacard: move atr setting from macro to function, Alon Levy, 2013/03/18
- [Qemu-devel] [PATCH 18/26] hw/usb/dev-smartcard-reader.c: copy atr's protocol to ccid's parameters (adds todo's), Alon Levy, 2013/03/18
- [Qemu-devel] [PATCH 21/26] dev-smartcard-reader: reuse usb.h definitions, Alon Levy, 2013/03/18
- [Qemu-devel] [PATCH 26/26] libcacard/cac.c: questionable change to single return of big switch functions, Alon Levy, 2013/03/18
- Re: [Qemu-devel] [PATCH 00/26] ccid and libcacard fixes for windows/mingw, Alon Levy, 2013/03/18