Re: [Qemu-devel] [PATCH 07/11] qemu-char: Move incrementing of avail_connections to qdev-properties-system

[Hans de Goede]

Hi,

On 03/27/2013 03:58 PM, Paolo Bonzini wrote:
> Il 27/03/2013 15:09, Hans de Goede ha scritto:
> > Hi,
> >
> > On 03/26/2013 02:50 PM, Paolo Bonzini wrote:
> >
> > <snip>
> >
> > > > 1) For most problematic devices, the proper fix would be to make them
> > > > use a chardev qdev property for there chardev usage, and then this
> > > > would be automatically fixed, agreed?
> > >
> > > At least on x86, all devices already use a chardev qdev property.
> >
> > Yes on x86 maybe, but a lot of the other serial-port emulations are
> > still using serial_hds directly, making proper avail_connections tracking
> > a pain.
>
> serial_hds is still passed to most devices via a chardev qdev property.

Most, yes but not all, which is why I wrote "using serial_hds *directly*",
anyways see the patch which I send a while back which tries to deal with
all the *direct* serial_hds users, as well as with the monitor, and some
code which does chardev creation completely on its own.

Regards,

Hans