[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support |
Date: |
Wed, 27 Mar 2013 16:26:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 27/03/2013 13:21, Stefan Berger ha scritto:
>
> With the above file naming and directory placement I followed the
> pattern of
>
> backends/rng.c
> include/qemu/rng.h
>
> So are you planning on having them renamed and moved as well?
Uff, we're really bad at consistent naming. :)
Given the above, I guess backends/tpm.c is fine. Then let's do the
following:
include/tpm/tpm.h -> include/sysemu/tpm.h
include/qemu/rng.h -> include/backends/rng.h
your new include -> include/backends/tpm.h
> My intention was to have tpm_passthrough moved into backends/.
I'm not sure that is the right thing to do since tpm_passthrough has
dependencies on DeviceState. It is not a pure backend, and if I
understand correctly it would likely not work with other TPM front-ends
than tpm_tis.c
> There's a file tpm/tpm_backend.c -- you want me to rename this one even
> though its located in a different directory?
tpm_backend.c and tpm_backend.h seem misnamed to begin with, so that
would be a separate but welcome change.
> Since I am not running a git repository any move/rename would be a
> deletion of a file plus its addition.
I don't understand.
Paolo