[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] qdev: add qdev_{create, free} tracepoints
From: |
Kazuya Saito |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] qdev: add qdev_{create, free} tracepoints |
Date: |
Thu, 28 Mar 2013 14:56:26 +0900 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 |
(2013/03/27 20:03), Andreas Färber wrote:> Am 22.03.2013 09:29, schrieb Kazuya
Saito:
>> This patch adds tracepoints at creating and removing virtual
>> devices. It is useful for investigation of trouble related to virtual
>> devices.
>>
>> Signed-off-by: Kazuya Saito <address@hidden>
>
> I would prefer not to do this. I had previously posted a patch to remove
> qdev_free() in favor of using the QOM function object_unparent()
> directly, which adding stuff to qdev_free() would interfere with. And
> you should rather add a tracepoint to object_new() or better to
> object_initialize() than into the legacy qdev_create() - which doesn't
> cover qdev_try_create() btw. Either way, adding new tracepoints with the
> legacy "qdev" in the name is ugly.
Just as I replied to Paolo, I won't add these tracepoints. Thank you for
your good information.
> Regards,
> Andreas
>
> P.S. Your patches arrived in HTML format, please check your workflow.
I checked and modified the setting. Did this mail arrive in plain-text?
Kazuya
- [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Kazuya Saito, 2013/03/22
- [Qemu-devel] [PATCH 1/5] vl: add runstate_set tracepoint, Kazuya Saito, 2013/03/22
- [Qemu-devel] [PATCH 2/5] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints, Kazuya Saito, 2013/03/22
- [Qemu-devel] [PATCH 3/5] kvm-all: add kvm_run_exit tracepoint, Kazuya Saito, 2013/03/22
- [Qemu-devel] [PATCH 4/5] qdev: add qdev_{create,free} tracepoints, Kazuya Saito, 2013/03/22
- [Qemu-devel] [PATCH 5/5] qdev-monitor: add device_add tracepoint, Kazuya Saito, 2013/03/22
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Paolo Bonzini, 2013/03/22
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Kazuya Saito, 2013/03/26
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Paolo Bonzini, 2013/03/26
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Kazuya Saito, 2013/03/27
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Paolo Bonzini, 2013/03/27
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Kazuya Saito, 2013/03/28
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Paolo Bonzini, 2013/03/28
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Anthony Liguori, 2013/03/28
- Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles, Stefan Hajnoczi, 2013/03/28