qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 1/2] hw/i386/pc: fix possible segment fault for p


From: liguang
Subject: [Qemu-devel] [PATCH v2 1/2] hw/i386/pc: fix possible segment fault for port92_write
Date: Thu, 28 Mar 2013 17:03:01 +0800

e.g.
$qemu-system-x86_64 -device port92
will report segment fault,
for port92_write try a un-allocated
assignment for a20_out.
so check before this assignment.

Signed-off-by: liguang <address@hidden>
---
 hw/i386/pc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 09fb728..b881314 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -444,7 +444,9 @@ static void port92_write(void *opaque, hwaddr addr, 
uint64_t val,
 
     DPRINTF("port92: write 0x%02x\n", val);
     s->outport = val;
-    qemu_set_irq(*s->a20_out, (val >> 1) & 1);
+    if (s->a20_out) {
+        qemu_set_irq(*s->a20_out, (val >> 1) & 1);
+    }
     if (val & 1) {
         qemu_system_reset_request();
     }
-- 
1.7.2.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]