[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: reverse the priority when commit
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] memory: reverse the priority when commit |
Date: |
Thu, 28 Mar 2013 14:44:32 +0000 |
On 28 March 2013 08:08, Liu Ping Fan <address@hidden> wrote:
> In theroy, the high priority should commit earlier, it is the same
> reason as the sequence of "Lower = earlier (during add), later (during del)"
Hi. Could you give a bit more detail about the reason for this
change, please? Do any of our existing commit hooks currently
care about the order in which they're called (ie is this fixing
a bug), or is there some use case that would care in future?
This change may well be right but it's not immediately obvious
that begin/commit are a paired set in the same way as (say)
add/del and log_start/log_stop, so more rationale would be
helpful.
thanks
-- PMM