[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 05/11] savevm: add error parameter to qemu_savevm
From: |
Pavel Hrdina |
Subject: |
[Qemu-devel] [PATCH v3 05/11] savevm: add error parameter to qemu_savevm_state_complete() |
Date: |
Thu, 28 Mar 2013 17:47:09 +0100 |
Signed-off-by: Pavel Hrdina <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
include/sysemu/sysemu.h | 2 +-
migration.c | 2 +-
savevm.c | 5 +++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index af4f699..9e6a4a9 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -77,7 +77,7 @@ void qemu_savevm_state_begin(QEMUFile *f,
const MigrationParams *params,
Error **errp);
int qemu_savevm_state_iterate(QEMUFile *f, Error **errp);
-void qemu_savevm_state_complete(QEMUFile *f);
+void qemu_savevm_state_complete(QEMUFile *f, Error **errp);
void qemu_savevm_state_cancel(void);
uint64_t qemu_savevm_state_pending(QEMUFile *f, uint64_t max_size);
int qemu_loadvm_state(QEMUFile *f);
diff --git a/migration.c b/migration.c
index e9d2f40..c891a45 100644
--- a/migration.c
+++ b/migration.c
@@ -525,7 +525,7 @@ static void *migration_thread(void *opaque)
old_vm_running = runstate_is_running();
vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
qemu_file_set_rate_limit(s->file, INT_MAX);
- qemu_savevm_state_complete(s->file);
+ qemu_savevm_state_complete(s->file, NULL);
qemu_mutex_unlock_iothread();
if (!qemu_file_get_error(s->file)) {
migrate_finish_set_state(s, MIG_STATE_COMPLETED);
diff --git a/savevm.c b/savevm.c
index 575f1b2..7598934 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1823,7 +1823,7 @@ int qemu_savevm_state_iterate(QEMUFile *f, Error **errp)
return ret;
}
-void qemu_savevm_state_complete(QEMUFile *f)
+void qemu_savevm_state_complete(QEMUFile *f, Error **errp)
{
SaveStateEntry *se;
int ret;
@@ -1848,6 +1848,7 @@ void qemu_savevm_state_complete(QEMUFile *f)
trace_savevm_section_end(se->section_id);
if (ret < 0) {
qemu_file_set_error(f, ret);
+ error_setg(errp, "failed to complete vmstate save");
return;
}
}
@@ -1933,7 +1934,7 @@ static int qemu_savevm_state(QEMUFile *f)
ret = qemu_file_get_error(f);
if (ret == 0) {
- qemu_savevm_state_complete(f);
+ qemu_savevm_state_complete(f, NULL);
ret = qemu_file_get_error(f);
}
if (ret != 0) {
--
1.8.1.4
- [Qemu-devel] [PATCH v3 00/11] convert savevm to use qapi and introduce qmp command, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 01/11] block: add error parameter to bdrv_snapshot_create() and related functions, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 02/11] block: add error parameter to del_existing_snapshots(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 04/11] savevm: add error parameter to qemu_savevm_state_iterate(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 03/11] savevm: add error parameter to qemu_savevm_state_begin(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 05/11] savevm: add error parameter to qemu_savevm_state_complete(),
Pavel Hrdina <=
- [Qemu-devel] [PATCH v3 06/11] savevm: add error parameter to qemu_savevm_state(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_snapshot_create, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 10/11] savevm: update return value from qemu_savevm_state, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 11/11] savevm: add force parameter to HMP command and return snapshot info, Pavel Hrdina, 2013/03/28