[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_s
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_snapshot_create |
Date: |
Thu, 28 Mar 2013 15:53:44 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/28/2013 10:47 AM, Pavel Hrdina wrote:
> If we provide error message we don't have to also provide return
> value because we could check if there is any error message or not.
>
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
> block.c | 24 ++++++++++--------------
> block/qcow2-snapshot.c | 12 +++++-------
> block/qcow2.h | 6 +++---
> block/rbd.c | 15 ++++++---------
> block/sheepdog.c | 9 ++++-----
> include/block/block.h | 6 +++---
> include/block/block_int.h | 6 +++---
> qemu-img.c | 9 ++++-----
> savevm.c | 4 ++--
> 9 files changed, 40 insertions(+), 51 deletions(-)
>
> @@ -2018,11 +2019,9 @@ static int img_snapshot(int argc, char **argv)
> sn.date_sec = tv.tv_sec;
> sn.date_nsec = tv.tv_usec * 1000;
>
> - ret = bdrv_snapshot_create(bs, &sn, NULL);
> - if (ret) {
> - error_report("Could not create snapshot '%s': %d (%s)",
> - snapshot_name, ret, strerror(-ret));
> - }
> + local_err = NULL;
> + bdrv_snapshot_create(bs, &sn, &local_err);
> + ret = qemu_img_handle_error(local_err);
This sets ret==1 on error, but bdrv_snapshot_create used to return <0 on
error. Then again, the tail of img_snapshot() normalizes all errors to
a 'return 1'. Took me a few minutes to see, but no problem after all.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 01/11] block: add error parameter to bdrv_snapshot_create() and related functions, (continued)
- [Qemu-devel] [PATCH v3 02/11] block: add error parameter to del_existing_snapshots(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 04/11] savevm: add error parameter to qemu_savevm_state_iterate(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 03/11] savevm: add error parameter to qemu_savevm_state_begin(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 05/11] savevm: add error parameter to qemu_savevm_state_complete(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 06/11] savevm: add error parameter to qemu_savevm_state(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_snapshot_create, Pavel Hrdina, 2013/03/28
- Re: [Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_snapshot_create,
Eric Blake <=
- [Qemu-devel] [PATCH v3 10/11] savevm: update return value from qemu_savevm_state, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 11/11] savevm: add force parameter to HMP command and return snapshot info, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 07/11] qapi: Convert savevm, Pavel Hrdina, 2013/03/28