Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block

[Wenchao Xia]

于 2013-3-28 19:09, Kevin Wolf 写道:
> Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben:
> >    With these parameters, user can choose the information to be showed,
> > to avoid message flood in the montior.
> >
> > Signed-off-by: Wenchao Xia <address@hidden>
>
> Aha, so here you actually introduce the 'device' parameter. If you can
> have this patch first, and only then patch 16, then limiting the new
> output to the form with a device specified should be trivial.
  It is a bit indirect that "info block" and "info block <device>"
show different on single device, so I introduced additional parameter
'-b' to filter out info. With more thinking, I think it should be
{
        .name       = "block",
        .help       = "show the block devices",
        .args_type  = "verbose:-v,device:B?",
        .params     = "[-v] [device]",
        .help       = "show info of one block device or all block devices "
                      "and detail of images with -v option",
}
  Then by default "info block" so brief summary as old time. Since the
"-v" parameter is filtering something out not present on patch 15,
so I can't move this patch forward, hope you are OK with it.

> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -2455,9 +2455,10 @@ static mon_cmd_t info_cmds[] = {
> >       },
> >       {
> >           .name       = "block",
> > -        .args_type  = "",
> > -        .params     = "",
> > -        .help       = "show the block devices",
> > +        .args_type  = "backing:-b,device:B?",
> > +        .params     = "[-b] [device]",
> > +        .help       = "show info of one block device or all block devices "
> > +                      "[and info of backing images with -b option",
>
> That '[' doesn't look intentional?
  my hand shaking... will correct it.

> Kevin


--
Best Regards

Wenchao Xia