Re: [Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions

[Aurelien Jarno]

On Fri, Mar 29, 2013 at 12:46:49AM +0100, Edgar E. Iglesias wrote:
> On Fri, Mar 29, 2013 at 12:36:29AM +0100, Aurelien Jarno wrote:
> > Signed-off-by: Aurelien Jarno <address@hidden>
> 
> Hi Aurelien,
> 
> Nice patches!
> 
> A question - The sbox tables are already available but in
> a different format in util/aes.c. Would it make sense to
> reuse (see Te4 and Td4) ?
> 

It looks like it's possible to reuse the Te4 and Td4 tables from there,
it should also be possible to used Te0-Te3 for aesenc and Td0-Td3 for
aesdec. That said it might not simplify the code a lot, as aesimc and 
aeskeygenassist are only doing part of the aes process.

I will look at that more in details later and I will try to come with
a solution to reuse the code from aes.c.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net