[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 01/18] tcg-arm: Fix local stack frame
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 01/18] tcg-arm: Fix local stack frame |
Date: |
Sat, 30 Mar 2013 21:45:42 +0000 |
On 30 March 2013 21:19, Richard Henderson <address@hidden> wrote:
> On 2013-03-30 14:14, Peter Maydell wrote:
>>
>> If you're doing a sub sp, sp, #n anyway, you might as well
>> add 4 to that and drop the save/load of r12 from the stmdb/ldmia.
>> It was only in there to save having an extra sub/add insn.
>
> Fair enough, not that it ought to make a difference to the cycle
> count.
Yeah, the TRMs suggest the ARM9 was the last to do ldm/stm
at 32 bits per cycle, and I'm guessing the prologue isn't
actually a sufficiently hot path to be worth worrying about
individual cycles anyway. I just felt it would be a bit tidier.
-- PMM
- [Qemu-devel] [PATCH v4 00/18] tcg-arm improvements, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 02/18] tcg-arm: Use bic to implement and with constant, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 03/18] tcg-arm: Handle negated constant arguments to and/sub, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 04/18] tcg-arm: Allow constant first argument to sub, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 05/18] tcg-arm: Use tcg_out_dat_rIN for compares, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 06/18] tcg-arm: Handle constant arguments to add2/sub2, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 07/18] tcg-arm: Improve constant generation, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 08/18] tcg-arm: Implement deposit for armv7, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 09/18] tcg-arm: Implement division instructions, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 10/18] tcg-arm: Use TCG_REG_TMP name for the tcg temporary, Richard Henderson, 2013/03/30
- [Qemu-devel] [PATCH v4 11/18] tcg-arm: Use R12 for the tcg temporary, Richard Henderson, 2013/03/30