[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-ppc: fix nego and subf*o instructions
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] target-ppc: fix nego and subf*o instructions |
|
Date: |
Sun, 31 Mar 2013 18:15:55 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/31/2013 05:33 PM, Aurelien Jarno wrote:
> The overflow computation of nego and subf*o instructions has been broken
> in commit ffe30937. Contrary to other targets, the instruction is subtract
> from an not subtract on PowerPC.
>
> This patch fixes the issue by using the correct argument in the xor
> computation. Thanks to Peter Maydell for the hint.
>
> With this change the PPC emulation passes the Gwenole Beauchesne
> testsuite again.
>
> Cc: Alexander Graf <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
> target-ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~