Re: [Qemu-devel] [Bug 1154328] [NEW] qemu locks up on typing 41 characters at once into serial console

[Aurelien Jarno]

On Mon, Apr 01, 2013 at 12:26:16PM +0530, Amit Shah wrote:
> On (Tue) 12 Mar 2013 [21:31:29], Andreas Gustafsson wrote:
> 
> >   Now cut-and-paste a string containing at least 41 characters into the
> >   terminal window.  I used a string containing 41 copies of the letter
> >   "X".  You can use other strings, but beware of pasting strings
> >   containing valid shell commands, as they may end up being executed on
> >   the host (see below).
> > 
> >   If your copy of qemu is suffering from the bug, it will lock up.  Not
> >   only will the virtual machine no longer respond to keystrokes, but
> >   qemu itself will no longer respond to commands such as "control-a c".
> >   You will have to kill it from a different terminal window.  When the
> >   qemu process is killed, any pasted characters after the first 40 will
> >   be read and executed by the host shell, suggesting that they were never
> >   even read by the qemu process.  As I had typed a return after pasting
> >   the 41 X:es, the host shell executed the command "X", thereby
> >   accidentally attempting (unsuccessfully) to start an X server.
> > 
> >   "git bisect" implicates the following commit:
> > 
> >     commit a29753f8aa79a34a324afebe340182a51a5aef11
> >     Author: Anthony Liguori <address@hidden>
> >     Date:   Tue Mar 5 23:21:19 2013 +0530
> > 
> >         qemu-char: convert fd_chr to use a GIOChannel
> > 
> >            This uses the newly introduced IOWatchPoll source.
> 
> Does
> 
> [PATCH] qemu-char: rewrite io_channel_send_all and drop the '_all' suffix
> 
> that's on the list help?

No, it doesn't.

> If not, does reverting fcfb4d6aae611d1f804d486d3c998000912c4c81 help?
> 
> (That is "serial: add flow control to transmit").

It also doesn't help.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net