[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown |
|
Date: |
Tue, 02 Apr 2013 12:03:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.3 |
On 04/01/13 18:57, Bruce Rogers wrote:
> While investigating why a 32 bit Windows 2003 guest wasn't able to
> successfully perform a shutdown /h, it was discovered that commit
> afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the
> initialization of the s4_val used to handle s4 shutdown.
> Initialize the value as before.
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -474,6 +474,7 @@ static const MemoryRegionOps acpi_pm_cnt_ops = {
>
> void acpi_pm1_cnt_init(ACPIREGS *ar, MemoryRegion *parent)
> {
> + ar->pm1.cnt.s4_val = 2;
The '2' used to come from PIIX4PMState->s4_val before commit
afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4, see piix4_pm_properties, this
behavior should be maintained IMHO.
cheers,
Gerd