[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitializ
From: |
Nicholas A. Bellinger |
Subject: |
Re: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs |
Date: |
Tue, 02 Apr 2013 16:16:54 -0700 |
On Tue, 2013-04-02 at 15:01 +0300, Michael S. Tsirkin wrote:
> On Mon, Apr 01, 2013 at 11:58:21PM +0000, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <address@hidden>
> >
> > Hi folks,
> >
> > This series adds a virtio_queue_valid() for use by virtio-pci code in
> > order to prevent opreations upon uninitialized VQs, which is currently
> > expected to occur during seabios setup of virtio-scsi with in-flight
> > vhost-scsi-pci device code.
> >
> > On the vhost side, it also adds virtio_queue_valid() sanity checks in
> > vhost_virtqueue_[start,stop]() and vhost_verify_ring_mappings() in order
> > to skip the same uninitialized VQs.
> >
> > Changes from v1:
> > - Remove now unnecessary virtio_queue_get_num() calls in virtio-pci.c
> > - Add virtio_queue_valid() calls in vhost_virtqueue_[start,stop]()
> >
> > Please review.
> >
> > --nab
>
> Looks reasonable.
> Acked-by: Michael S. Tsirkin <address@hidden>
>
Thanks MST!
Anthony, do you want to pick these up now..? Or shall I include in the
next vhost-scsi-pci PATCH-v3 series..?
--nab
> So - does this fix the issues you saw with vhost-scsi?
>
> > Michael S. Tsirkin (1):
> > virtio: add API to check that ring is setup
> >
> > Nicholas Bellinger (2):
> > virtio-pci: Add virtio_queue_valid checks ahead of
> > virtio_queue_get_num
> > vhost: Skip uninitialized VQs in vhost_virtqueue_[start,stop]
> >
> > hw/vhost.c | 12 ++++++++++++
> > hw/virtio-pci.c | 34 +++++++++++++++-------------------
> > hw/virtio.c | 5 +++++
> > hw/virtio.h | 1 +
> > 4 files changed, 33 insertions(+), 19 deletions(-)
> >
> > --
> > 1.7.2.5
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to address@hidden
> More majordomo info at http://vger.kernel.org/majordomo-info.html
- [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs, Nicholas A. Bellinger, 2013/04/01
- [Qemu-devel] [PATCH-v2 1/3] virtio: add API to check that ring is setup, Nicholas A. Bellinger, 2013/04/01
- [Qemu-devel] [PATCH-v2 3/3] vhost: Skip uninitialized VQs in vhost_virtqueue_[start, stop], Nicholas A. Bellinger, 2013/04/01
- [Qemu-devel] [PATCH-v2 2/3] virtio-pci: Add virtio_queue_valid checks ahead of virtio_queue_get_num, Nicholas A. Bellinger, 2013/04/01
- Re: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs, Michael S. Tsirkin, 2013/04/02
- Re: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs,
Nicholas A. Bellinger <=