[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_tran
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction |
|
Date: |
Wed, 3 Apr 2013 11:03:51 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 03.04.2013 um 07:35 hat Wenchao Xia geschrieben:
> δΊ 2013-4-2 21:59, Kevin Wolf ει:
> >Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben:
> >> Last operaton should be cancelled first.
> >>
> >>Signed-off-by: Wenchao Xia <address@hidden>
> >
> >Should it? This commit message does little to convince me.
> >
> >Kevin
> >
> I think so, if two request are "snapshot_blkdev ide0 newimage.qcow2",
> "snapshot_blkdev_internal ide0 snap0", then in rollback delete of
> snap0 would be wrong.
I think this problem exists only because you didn't properly separate
the prepare and the commit stage. If any changes only took effect in a
non-failing commit stage, then you don't ever have to delete a snapshot.
Instead, you just abort the creation of the snapshot.
Kevin
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, (continued)
[Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction, Wenchao Xia, 2013/04/01