[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extenda
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable |
Date: |
Wed, 03 Apr 2013 11:17:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 03/04/2013 11:02, Wenchao Xia ha scritto:
>>
> Sorry I haven't state it clearly. What about bdrv_snapshot_create()
> operation? If it need to be rolled back, I think bdrv_snapshot_delete()
> will get called and it may fail. But in most case if
> bdrv_snapshot_create() succeed before, the bdrv_snapshot_delete should
> succeed also, so if fail there may be unexpected error below, could
> assert be used for this?
No. Transactionable means that commit and rollback cannot fail.
For bdrv_snapshot_create() it is the same as for bdrv_snapshot_delete()
(the overview I wrote was for qcow2_write_snapshots, which is the common
part of bdrv_snapshot_create() and bdrv_snapshot_delete()).
Please do one thing at a time. Split the series in multiple pieces if
possible. Otherwise you will just fail, and you will have wasted a lot
of your and other people's time.
Paolo
- [Qemu-devel] [PATCH 0/3] block: make qmp_transaction extendable, Wenchao Xia, 2013/04/01
- [Qemu-devel] [PATCH 1/3] block: add function deappend(), Wenchao Xia, 2013/04/01
- [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Wenchao Xia, 2013/04/01
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Kevin Wolf, 2013/04/02
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Wenchao Xia, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Wenchao Xia, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Kevin Wolf, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Wenchao Xia, 2013/04/03
Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Stefan Hajnoczi, 2013/04/17
[Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction, Wenchao Xia, 2013/04/01