Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the new API.

[Amit Shah]

On (Fri) 29 Mar 2013 [10:02:39], address@hidden wrote:
> From: KONRAD Frederic <address@hidden>
> 
> Here the virtio-serial-pci is modified for the new API. The device
> virtio-serial-pci extends virtio-pci. It creates and connects a
> virtio-serial during the init. The properties are not changed.

> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index 6db67bf..83f15b6 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c

> -static Property virtio_serial_properties[] = {
> -    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, 
> VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
> -    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),

[snip]

> +static Property virtio_serial_pci_properties[] = {
> +    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags,
> +                    VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
> +    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors,
> +                    DEV_NVECTORS_UNSPECIFIED),

The change in commit 554f1997f0328bc259454239db64b20b3376d9a6 got lost
in a rebase -- this should be 2 instead of DEV_NVECTORS_UNSPECIFIED.

                Amit