Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/

[Michael S. Tsirkin]

On Wed, Apr 03, 2013 at 01:51:23PM +0200, Paolo Bonzini wrote:
> Il 03/04/2013 12:51, Michael S. Tsirkin ha scritto:
> >>> > >  default-configs/i386-softmmu.mak   | 4 ++++
> >>> > >  default-configs/x86_64-softmmu.mak | 4 ++++
> >>> > >  hw/i386/Makefile.objs              | 7 ++-----
> >>> > >  hw/isa/Makefile.objs               | 6 ++++++
> >>> > >  hw/{ => isa}/debugexit.c           | 0
> >>> > >  hw/{ => isa}/lpc_ich9.c            | 0
> >>> > >  hw/{ => isa}/pc-testdev.c          | 0
> >> > 
> >> > This at least seems wrong. debug devices should be in
> >> > hw/debug or hw/test. And it does not matter that LPC
> >> > uses some ISA ports. It's a chipset device.
> >> > So hw/chipset or something ...
> >> > 
> > Maybe hw/system/ or hw/bridge/
> > 
> > 
> 
> lpc_ich9.c is an ISA bridge, hence it is in hw/isa.
> 
> debugexit and pc-testdev are exceptions.  I didn't really have a better
> place.
> 
> Paolo

hw/misc

Please don't just move files to random places: if unsure,
leave files in place.