qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for p


From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors
Date: Wed, 3 Apr 2013 11:31:45 -0400

On Wed, 3 Apr 2013 11:24:38 -0400
Luiz Capitulino <address@hidden> wrote:

> On Wed, 3 Apr 2013 10:05:40 -0500
> mdroth <address@hidden> wrote:
> 
> > On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote:
> > > On Wed, 27 Mar 2013 10:10:42 +0100
> > > Stefan Hajnoczi <address@hidden> wrote:
> > > 
> > > > There are several places where QEMU accidentally relies on the 
> > > > O_NONBLOCK state
> > > > of passed file descriptors.  Exposing O_NONBLOCK state makes it part of 
> > > > the QMP
> > > > API whenever getfd or fdset_add_fd are used!
> > > > 
> > > > Whether or not QEMU will use O_NONBLOCK is an implementation detail and 
> > > > should
> > > > be hidden from QMP clients.
> > > > 
> > > > This patch series addresses this in 3 steps:
> > > 
> > > Nice series:
> > > 
> > > Applied to the qmp branch, thanks.
> > 
> > Hi Luiz,
> > 
> > Eric/mjt have noted that this series fixes a number of issues in 1.4.0
> > and have requested it for 1.4.1
> > 
> > http://thread.gmane.org/gmane.comp.emulators.qemu/203851
> > 
> > The cut-off for 1.4.1 is Tuesday. Do you plan to send a pull for these soon?
> 
> Sure, I can do that. And thanks to remind me.

Actually, I can't cherry-pick it cleanly.

Stefan, would you mind to backport this series to v1.4.1 yourself?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]