[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint |
Date: |
Thu, 4 Apr 2013 15:22:34 +0100 |
On 4 April 2013 15:04, Paolo Bonzini <address@hidden> wrote:
> Il 04/04/2013 15:56, Peter Maydell ha scritto:
>> I think this define should go in an include file in
>> linux-user/m68k/ -- it's ABI specific and we should
>> be aiming to isolate ABI specific info in linux-user/
>> rather than having it leaking into target-* and thus
>> into the system emulation code.
>>
>> Otherwise patch looks good.
>
> That would create 10 empty files, and two files between one and three
> lines of code. I would just put those in include/exec/user/abitypes.h.
I would prefer not to add more code with TARGET ifdefs.
(I have a vague plan to split up some of the current linux-user
code which is #ifdefs in source files in linux-user into per
target source files which make just pulls in as appropriate.)
Also, separate files in linux-user/foo encourage authors of
new targets to think "do I need to put something in my new
target's version of this?" whereas #ifdef TARGET_FOO in
common source files don't.
Riku's the linux-user maintainer, though...
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target, (continued)
- Re: [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target, Peter Maydell, 2013/04/04
- Re: [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target, Paolo Bonzini, 2013/04/04
- Re: [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target, Peter Maydell, 2013/04/04
- Re: [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target, Paolo Bonzini, 2013/04/04
- Re: [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target, Peter Maydell, 2013/04/04
[Qemu-devel] [PATCH v2 07/10] elfload: use abi_llong/ullong instead of target_llong/ullong, Paolo Bonzini, 2013/04/03
[Qemu-devel] [PATCH v2 08/10] configure: move CONFIG_QEMU_LDST_OPTIMIZATION to config-host.mak, Paolo Bonzini, 2013/04/03
[Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint, Paolo Bonzini, 2013/04/03
[Qemu-devel] [PATCH v2 09/10] configure: move common libraries to config-host.mak, Paolo Bonzini, 2013/04/03
[Qemu-devel] [PATCH v2 10/10] configure: CONFIG_NO_XEN is duplicated, Paolo Bonzini, 2013/04/03