[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 12/14] pl330: Don't inhibit ES bits on INTEN
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 12/14] pl330: Don't inhibit ES bits on INTEN |
Date: |
Fri, 5 Apr 2013 18:13:17 +0100 |
From: Peter Crosthwaite <address@hidden>
This if-else logic inhibits setting of the event status (ES) bits
when interrupts are enabled. This is incorrect. ES should be set
regardless on INTEN state. INTEN only inhibits the signalling of
events to PL330 threads, not setting of the ES register.
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
hw/pl330.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/pl330.c b/hw/pl330.c
index 1a04773..60aa4a8 100644
--- a/hw/pl330.c
+++ b/hw/pl330.c
@@ -870,9 +870,8 @@ static void pl330_dmasev(PL330Chan *ch, uint8_t opcode,
uint8_t *args, int len)
ch->parent->int_status |= (1 << ev_id);
DB_PRINT("event interrupt raised %d\n", ev_id);
qemu_irq_raise(ch->parent->irq[ev_id]);
- } else {
- ch->parent->ev_status |= (1 << ev_id);
}
+ ch->parent->ev_status |= (1 << ev_id);
}
static void pl330_dmast(PL330Chan *ch, uint8_t opcode, uint8_t *args, int len)
--
1.7.9.5
- [Qemu-devel] [PULL 00/14] arm-devs queue, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 04/14] vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 14/14] hw/nand.c: Fix nand erase operation, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 03/14] hw/arm_mptimer: Save the timer state, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 12/14] pl330: Don't inhibit ES bits on INTEN,
Peter Maydell <=
- [Qemu-devel] [PATCH 11/14] pflash_cfi01: Implement migration support, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 05/14] hw/sd.c: fix migration of dynamically allocated buffer "buf", Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 01/14] hw/arm/nseries: don't print to stdout or stderr, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 13/14] cadence_uart: Flush queued characters on reset, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 09/14] hw/arm_gic_common: Use vmstate struct rather than save/load functions, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 08/14] arm_gic: Fix sizes of state fields in preparation for vmstate support, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 10/14] pflash_cfi01: Drop unused 'bypass' field, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 07/14] vmstate: Add support for two dimensional arrays, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 02/14] pl050: Don't send always-constant is_mouse field, Peter Maydell, 2013/04/05
- [Qemu-devel] [PATCH 06/14] hw/onenand.c: fix migration of dynamically allocated buffer "otp", Peter Maydell, 2013/04/05