Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info

[Kevin Wolf]

Am 02.04.2013 um 13:47 hat Wenchao Xia geschrieben:
> v11:
>   General change:
>   5/17: check if snapshot > 0 on success in caller, add comments on the
> function says that caller need to check it on success.
>   7/17: check if snapshot > 0 on success before set info->has_snapshots.
> 
>   Address Eric's comments:
>   5/17: use error_setg_errno instead of strerror().
>   12/17: also move bdrv_snapshot_dump() since it need to be changed using
> GString later.
>   13/17: using GString as buffer.
>   14/17: using GString to dump snapshot info.
>   16/17: using GString to dump image info.
> 
>   Address Kevin's comments:
>   11/17: return void for bdrv_query_info().
>   17/17: spell fix in help message, using parameter "-v" to show
> verbose info.

In patch 11 I commented on what I think is an error handling bug. The
rest of the series is:

Reviewed-by: Kevin Wolf <address@hidden>