Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

[KONRAD Frédéric]

On 05/04/2013 17:36, Anthony Liguori wrote:
> address@hidden writes:
>
> > From: KONRAD Frederic <address@hidden>
> >
> > This is the next part of virtio-refactoring.
> >
> > Basically it creates virtio-serial device which extends virtio-device.
> > Then a virtio-serial can be connected on a virtio-bus.
> > virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too,
> > they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and
> > have a virtio-serial.
> >
> > You can checkout my branch here:
> >
> > git://project.greensocs.com/qemu-virtio.git virtio-serial-v5
> >
> > Note that it is nearly the same series as virtio-blk and virtio-scsi
> > refactoring.
> /home/aliguori/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel 
> /usr/local/share/qemu-jeos/kernel-x86_64-pc -initrd 
> .tmp-11584/initramfs-11584.img.gz -device isa-debug-exit -append console=ttyS0 
> seed=42872 -nographic -enable-kvm -hda .tmp-11584/disk-11584.img -M pc-0.13 
> -drive file=.tmp-11584/disk-11584.img,if=virtio,snapshot=on -device 
> virtio-balloon-pci -device virtio-serial -net nic,model=virtio -net user 
> -pidfile .tmp-11584/pidfile-11584.pid -qmp 
> unix:.tmp-11584/qmpsock-11584.sock,server,nowait
> qemu-system-x86_64: -device virtio-serial: No 'virtio-bus' bus found for
> device 'virtio-serial'
>
> I think we need to go back and name the devices 'virtio-serial-device'
> et al to avoid breaking aliases.
>
> Regards,
>
> Anthony Liguori
Hi Anthony,

I'm making a patch for that, and I'm wondering if the name in 
register_savevm must be changed too?

eg for virtio-balloon:

-    register_savevm(qdev, "virtio-balloon", -1, 1,
+    register_savevm(qdev, TYPE_VIRTIO_BALLOON, -1, 1,
                     virtio_balloon_save, virtio_balloon_load, s);

with TYPE_VIRTIO_BALLOON "virtio-balloon-device"?

Thanks,
Fred