[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero |
|
Date: |
Tue, 09 Apr 2013 13:27:36 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Il 09/04/2013 10:52, Markus Armbruster ha scritto:
>>> > This also removes the need to do something special on valgrind
>>> > (see commit c2a8238a, Support running QEMU on Valgrind, 2011-10-31).
>> Suggest to state explicitly that you effectively revert it.
>>
>> You left #define CONFIG_VALGRIND in, even though it's no longer used.
>> Intentional?
>
> Oh, there's both CONFIG_VALGRIND and CONFIG_VALGRIND_H. Nice. I'll
> send v2.
That confused me briefly, too :)
Make sure to address the mmap() error checking as well.