Re: [Qemu-devel] [PATCH 18/22] target-i386: move IOAPIC to ICC bus

[Paolo Bonzini]

Il 05/04/2013 16:37, Igor Mammedov ha scritto:
> +    const char *ioapic_name = "ioapic";
>  
>      if (kvm_irqchip_in_kernel()) {
> -        dev = qdev_create(NULL, "kvm-ioapic");
> -    } else {
> -        dev = qdev_create(NULL, "ioapic");
> -    }
> -    if (parent_name) {
> -        object_property_add_child(object_resolve_path(parent_name, NULL),
> -                                  "ioapic", OBJECT(dev), NULL);
> +        ioapic_name = "kvm-ioapic";
>      }
> -    qdev_init_nofail(dev);
> -    d = SYS_BUS_DEVICE(dev);
> -    sysbus_mmio_map(d, 0, IO_APIC_DEFAULT_ADDRESS);
> +    object_property_set_str(OBJECT(dev), ioapic_name, "ioapic-type", NULL);

Why do you need this?

Having the IOAPIC as a QOM child of the icc-bridge is not too important,
I think.  Perhaps not even too correct...

Paolo