[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] migration: drop is_write complications
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] migration: drop is_write complications |
Date: |
Tue, 09 Apr 2013 13:42:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> The same QEMUFile is never used for both read and write. Simplify
> the logic to simply look for presence or absence of the right ops.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Love this one.
> @@ -556,11 +557,7 @@ static void qemu_fill_buffer(QEMUFile *f)
> int len;
> int pending;
>
> - if (!f->ops->get_buffer)
> - return;
Why are we removing this test? this has nothing to do with the is_write
removal?
And yes, having a better way of knowing that the operations are there
looks like a good idea, but that is independent of this series.
Thanks, Juan.
[Qemu-devel] [PATCH 2/4] migration: use a single I/O operation when writev_buffer is not defined, Paolo Bonzini, 2013/04/08
[Qemu-devel] [PATCH 4/4] migration: simplify writev vs. non-writev logic, Paolo Bonzini, 2013/04/08